Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evans distribution using docker #559

Merged
merged 5 commits into from
Jul 14, 2022
Merged

Evans distribution using docker #559

merged 5 commits into from
Jul 14, 2022

Conversation

tarampampam
Copy link
Contributor

@tarampampam tarampampam commented Jul 13, 2022

Related issue: #558

@tarampampam tarampampam marked this pull request as ready for review July 13, 2022 14:44
@tarampampam
Copy link
Contributor Author

@ktr0731 All changes were tested on my side successfully. Your typical releasing flow was not affected - after the release publishing (eg. by goreleaser) docker image will be built and published in the GitHub container registry (in your namespace).

@tarampampam tarampampam changed the title Dockerfile & CI implemented Evans distribution using docker Jul 13, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #559 (9bc0093) into master (823938c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   79.88%   79.88%           
=======================================
  Files          57       57           
  Lines        3867     3867           
=======================================
  Hits         3089     3089           
  Misses        546      546           
  Partials      232      232           

Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@ktr0731 ktr0731 merged commit 0a10bde into ktr0731:master Jul 14, 2022
@ktr0731
Copy link
Owner

ktr0731 commented Jul 14, 2022

Published: https://github.com/ktr0731/evans/pkgs/container/evans

@tarampampam tarampampam deleted the docker branch July 14, 2022 14:34
@tarampampam
Copy link
Contributor Author

Woohoo! Could you please also enable this in the repo:

image

It would be useful for docker-users :)

@ktr0731
Copy link
Owner

ktr0731 commented Jul 15, 2022

Thank you. I enabled Packages 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants