Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-5448 Unmute legit SerializationException #3393

Merged
merged 1 commit into from
Feb 10, 2023
Merged

KTOR-5448 Unmute legit SerializationException #3393

merged 1 commit into from
Feb 10, 2023

Conversation

e5l
Copy link
Member

@e5l e5l commented Feb 6, 2023

No description provided.

@sandwwraith
Copy link

Don't you want to use serializerOrNull in serializerFromTypeInfo?

@e5l
Copy link
Member Author

e5l commented Feb 9, 2023

@sandwwraith, could you clarify what serializerOrNull we should use? We already using some serializerOrNull

ktor/ktor-shared/ktor-serialization/ktor-serialization-kotlinx/common/src/io/ktor/serialization/kotlinx/SerializerLookup.kt

Line 21 in bad1c2d

else module.serializerOrNull(type)
in the described case

@sandwwraith
Copy link

Ah, sorry, I didn't see that. Disregard my comment then.

@e5l e5l requested a review from marychatte February 10, 2023 07:42
@e5l e5l self-assigned this Feb 10, 2023
@e5l e5l marked this pull request as ready for review February 10, 2023 07:42
marychatte
marychatte approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@marychatte marychatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@e5l e5l merged commit 9be89d7 into main Feb 10, 2023
@e5l e5l deleted the e5l/prevent-muting-serialization-exception branch February 10, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marychatte marychatte marychatte approved these changes

Assignees

@e5l e5l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e5l @sandwwraith @marychatte