KTOR-5868 Fix the delimiter for a Cookie name-value pairs (#3739)

(cherry picked from commit 67e4f4e)
ktorio · Aug 30, 2023 · ce50296 · ce50296
1 parent d17b3d9
commit ce50296
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/ktor-client/ktor-client-core/common/src/io/ktor/client/engine/Utils.kt b/ktor-client/ktor-client-core/common/src/io/ktor/client/engine/Utils.kt
@@ -47,7 +47,8 @@ public fun mergeHeaders(
                 block(key, value)
             }
         } else {
-            block(key, values.joinToString(","))
+            val separator = if (HttpHeaders.Cookie == key) "; " else ","
+            block(key, values.joinToString(separator))
         }
     }
 

diff --git a/ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/plugins/CookiesTest.kt b/ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/plugins/CookiesTest.kt
@@ -246,5 +246,17 @@ class CookiesTest : ClientLoader() {
         }
     }
 
+    @Test
+    fun testSeparatedBySemicolon() = clientTests(listOf("Js")) {
+        test { client ->
+            client.get("$TEST_HOST/encoded") {
+                cookie("firstCookie", "first")
+                header("Cookie", "secondCookie=second")
+            }.bodyAsText().also {
+                assertEquals("firstCookie=first; secondCookie=second", it)
+            }
+        }
+    }
+
     private suspend fun HttpClient.getId() = cookies(hostname)["id"]!!.value.toInt()
 }