Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new locales - Update monthly.js #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jefferson
Copy link

Hi! Sorry about make commit in this way, but I didn't see any instruction about how make contributions here.
Now we have support for locales :)

We can use:
$('#mycalendar2').monthly({monthNames: 'pt-br'})

Default is 'en'.

Hi! Sorry about make commit in this way, but I didn't see any instruction about how make contributions here.
Now we have support for locales :)

We can use:
$('#mycalendar2').monthly({monthNames: 'pt-br'})

Default is 'en'.
@jefferson jefferson changed the title Update monthly.js Add support for new locales - Update monthly.js Oct 12, 2016
Add today as key in locale const and add check if options is undefined.
@kthornbloom
Copy link
Owner

Thank you! I will check this out & merge it in soon

@richardtallent
Copy link
Contributor

richardtallent commented Nov 27, 2016

We should implement this using Intl.DateTimeFormat for both the short month name and short weekday names, with fallback to English for the few modern browsers (Safari desktop) that don't yet support that standard. That way we don't have to carry all of these localized arrays in the code. Similarly, options.weekStart should be a number, not an English abbreviation.

Edit: I made the changes described above in pull request #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants