Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for homebrew python #19

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Add tests for homebrew python #19

merged 1 commit into from
Feb 10, 2021

Conversation

ktbarrett
Copy link
Owner

xref #4.

@ktbarrett ktbarrett mentioned this pull request Feb 9, 2021
Closed
21 tasks
@ktbarrett ktbarrett force-pushed the homebrew branch 3 times, most recently from 0315e93 to de26ff7 Compare February 9, 2021 04:41
@ktbarrett
Copy link
Owner Author

The test passes but I don't think it's correct. I am assuming there is actually a libpythonXXXX.so somewhere on the system. My guess is that is has the m suffix and isn't being searched for. Now I understand why the original code tried stripping and replacing the extension, it would find suffixes automatically. I'll need to iterate on this, I don't have a Mac OS X license to just poke around in.

@ktbarrett
Copy link
Owner Author

ktbarrett commented Feb 9, 2021 •
edited
Loading

I think the issue is the bad assumption that the shared library will end in .dylib. The code then tosses the value from LDLIBRARY.

@ktbarrett ktbarrett force-pushed the homebrew branch 2 times, most recently from 24ef62a to 862ee07 Compare February 10, 2021 03:09
@ktbarrett
Copy link
Owner Author

Nvm, I'm stupid. Apparently I don't know what a framework is.

@ktbarrett ktbarrett merged commit 4f5742e into master Feb 10, 2021
@ktbarrett ktbarrett deleted the homebrew branch February 10, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ktbarrett