Skip to content

Commit

Permalink
Fix style/lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
David Li authored and David Li committed Feb 5, 2019
1 parent 3cb51ba commit 111b3e6
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class FlightStreamWriter : public ipc::RecordBatchWriter {
: rpc_{std::move(rpc)},
descriptor_{descriptor},
schema_{schema},
pool_{default_memory_pool()} {};
pool_{default_memory_pool()} {}

Status WriteRecordBatch(const RecordBatch& batch, bool allow_64bit = false) override {
IpcPayload payload;
Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/client.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class ARROW_EXPORT FlightClient {

/// \brief Given a flight ticket and schema, request to be sent the
/// stream. Returns record batch stream reader
/// \param[in] ticket
/// \param[in] ticket The flight ticket to use
/// \param[in] schema the schema of the stream data as computed by
/// GetFlightInfo
/// \param[out] stream the returned RecordBatchReader
Expand All @@ -102,6 +102,7 @@ class ARROW_EXPORT FlightClient {

/// \brief Upload data to a Flight described by the given descriptor.
/// \param[in] descriptor the descriptor of the stream
/// \param[in] schema the schema for the data to upload
/// \param[out] stream a writer to write record batches to
/// \return Status
Status DoPut(const FlightDescriptor& descriptor, const std::shared_ptr<Schema>& schema,
Expand Down
5 changes: 2 additions & 3 deletions cpp/src/arrow/flight/server.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ class ARROW_EXPORT FlightDataStream {

/// \brief A basic implementation of FlightDataStream that will provide
/// a sequence of FlightData messages to be written to a gRPC stream
/// \param[in] reader produces a sequence of record batches
class ARROW_EXPORT RecordBatchStream : public FlightDataStream {
public:
/// \param[in] reader produces a sequence of record batches
explicit RecordBatchStream(const std::shared_ptr<RecordBatchReader>& reader);

std::shared_ptr<Schema> schema() override;
Expand All @@ -98,8 +98,7 @@ class ARROW_EXPORT FlightServerBase {

/// \brief Run an insecure server on localhost at the indicated port. Block
/// until server is shut down or otherwise terminates
/// \param[in] port
/// \return Status
/// \param[in] port the port to bind to
void Run(int port);

/// \brief Shut down the server. Can be called from signal handler or another
Expand Down
4 changes: 2 additions & 2 deletions integration/integration_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1006,9 +1006,9 @@ def _compare_flight_implementations(self, producer, consumer):

with producer.flight_server():
for json_path in self.json_files:
print('==========================================================')
print('=' * 58)
print('Testing file {0}'.format(json_path))
print('==========================================================')
print('=' * 58)

# Have the client upload the file, then download and
# compare
Expand Down

0 comments on commit 111b3e6

Please sign in to comment.