Remove all options when search input is empty to fix #25 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…till kept to the last results from server
…till kept to the last results from server
pjfsilva
changed the title
…till kept to the last results from server
…till kept to the last results from server Fixes a problem where all selected options where gone after input is set to empty
|
@pjfsilva - thanks for your contribution! This is great! Would it be possible for you to write a test for this in https://github.com/ksykulev/chosen-ajax-addition/blob/master/test/main.js ? That way if I upgrade chosen or make any additional changes I can know this feature will continue to work as intended. If you need help let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
This adds code to remove all options when search input is empty. This solves a problem where the options can be left there if you type something, get results and then delete everything from input