Move exclusion logic from click event to function #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working with Twitter Bootstrap 3, particularly with their tabbing features. Unfortunately, the only way to 'exclude' anything is to do so on the$.fn.smoothScroll, which the site I was working with didn't use -- they rolled their own click-event handler to call the $ .smoothScroll function. Thus, there was no way for me tell the plugin that I didn't want it to smooth scroll to tab contents, even with the $.smoothScroll('options', obj) overrides.
The change, then, moves that exclusion logic (almost as-is) from the click even handler to the smoothScroll function. That way, whether you indicate it in the $.fn.smoothScroll or come in later and apply it to optionOverrides, your exclusion will be honored.
(Note: This is my first "major" pull request, not sure if I did it right or built it right, etc, please forgive any shortcomings (and I'm of course open to your feedback!))