Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Add --installed flag to pkg list #600

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

bryanl
Copy link
Member

@bryanl bryanl commented Jun 8, 2018

Adds a new flag to pkg list that only lists installed packages.

2018-06-07_21-43-24

Signed-off-by: bryanl [email protected]

Adds a new flag to `pkg list` that only lists installed packages.

Signed-off-by: bryanl <[email protected]>
@bryanl bryanl requested a review from a team June 8, 2018 01:42
Copy link
Collaborator

@underrun underrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a lot of code to basically just do: ks pkg list | grep '*$' ... but other than this this totally looks good to me.

func (pl *PkgList) addRow(regName, libName string, isInstalled bool) []string {
row := []string{regName, libName}
if isInstalled {
row = append(row, pkgInstalled)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the star if we are only listing installed things?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to keep the column headings the same.

@bryanl bryanl merged commit f78b070 into ksonnet:master Jun 8, 2018
@bryanl bryanl deleted the list-installed-packages branch June 8, 2018 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants