Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh actions codecov #17

Merged
merged 23 commits into from
Nov 6, 2023
Merged

Gh actions codecov #17

merged 23 commits into from
Nov 6, 2023

Conversation

ksilligan
Copy link
Owner

Changes

Reason for changes

Related tickets

Tests

p-wysocki and others added 23 commits October 18, 2023 10:13
### Changes

Bump `numpy` version.

### Reason for changes

Current version causes issues in OpenVINO CI: intel-innersource/frameworks.ai.openvino.ci.product-configs#2803

### Related tickets

122802
…#2201)

### Changes

Added links to `OneFormer` and `InstructPix2Pix` OpenVINO notebooks
### Changes

* SE block ignored pattern is presented for Torch backend

![image](https://github.com/openvinotoolkit/nncf/assets/74656388/2bbf0d3c-ac9d-4db0-9c28-ff6b1bf299af)
* SE block ignored pattern for OV backend is adjusted
* NON_PATTERN_NODE_WITH_TYPE is introduced in the graph matcher


### Reason for changes

To align FQ layout between TORCH and OV backend for efficientnet_b0
model
To fix FQ placement for SE block:
Before: 

![image](https://github.com/openvinotoolkit/nncf/assets/74656388/7e8b27a3-fafc-41f9-ace2-1945bce32b65)
After:

![image](https://github.com/openvinotoolkit/nncf/assets/74656388/e4479c90-bd4f-47fb-b2c2-acd76a685030)


### Related tickets

121647

### Tests
* test_non_pattern_node_with_type for the graph matcher

Post training quantization manual build 180

| Model | Backend | Metric name | Metric value | Metric diff | Num FQ |
RAM MiB | Quant. time | Total time | Status |

|-------|----------------------|-------------|--------------|-------------|---------|---------|-------------|------------|---------|
| 1 | timm/efficientnet_b0 | OV | Acc@1 | 0.7688 | -0.0042 | 92 | 1033 |
0:00:25 | 1:03:58 | |
| 2 | timm/efficientnet_b0 | TORCH | Acc@1 | 0.7680 | -0.0049 | 92 | 892
| 0:00:48 | 1:04:27 |


* pattern manager tests
…rch backend (openvinotoolkit#2166)

### Changes

* "unbing" and "__matmul__" ops are added to torch patterns
* Dropout removing pass is added to function
`transform_to_inference_graph`
* LayerNorm and GroupNorm metatypes are added to ignored metatypes in
MinMax algorithm

### Reason for changes

To align quantization placement between OV and Torch backends for the
following models:
* timm/crossvit_9_240
* timm/deit3_small_patch16_224
* timm/swin_base_patch4_window7_224


### Related tickets

121647

### Tests
*  test_metatypes_to_ignore for quantization propagation solver
### Changes

- Added `ov_version` variable for the pytest in `test_examples`;
- Added `ov_version` variable for the pytest in the `test_install_*`;

### Reason for changes

- More flexible tests

### Related tickets

- 122860

### Tests

- Updated
…lkit#2212)

### Changes
As stated in the title

### Reason for changes
Common code has an own target now which is run using GH actions, no reason to run these tests additionally in the backend-specific targets.

### Related tickets
TBA

### Tests
Existing precommit scope
### Changes

Run the SmoothQuant and ChannelAlignment algorithms only for the
OpenVINO backend.

### Reason for changes

Only the OpenVINO backend supports SmoothQuant and ChannelAlignment
algorithms.

### Related tickets
N/A

### Tests
N/A
### Changes

Added cache_dir for OMZ models

### Reason for changes

* Сhanges made according to the requirements of the validation team

### Related tickets

<!--- Post the numerical ID of the ticket, if available -->

### Tests

<!--- How was the correctness of changes tested and whether new tests
were added -->
…notoolkit#2216)

### Changes

Made the QuantizationPreset.MIXED preset for ModelType.TRANSFORMER by
default.

### Reason for changes

Quantization of transformer-based models with QuantizationPreset.MIXED
preset shows the best accuracy w/o performance degradation.

### Related tickets

ref: 123235

### Tests
test_create_nncf_config
test_quantization_preset
- [ ] pass nncf + openvino-nightly tests - build#7

### Changes

<!--- What was changed (briefly), how to reproduce (if applicable), what
the reviewers should focus on -->

### Reason for changes

<!--- Why should the change be applied -->

### Related tickets

<!--- Post the numerical ID of the ticket, if available -->

### Tests

<!--- How was the correctness of changes tested and whether new tests
were added -->
### Changes

Using ov.save_model(...) in PTQ examples

### Reason for changes

ov.save_model(...) is introduced in OpenVINO==2023.1.0

### Related tickets

N/A

### Tests

examples
### Changes

- Removed `insert_bull_biases` method

### Reason for changes

- Inserting is not necessary since correcting the null biases is limited
by magnitude.
- Inserting of the new increases binary file size.

### Related tickets

- 120843
### Changes

Fix index out of range

### Reason for changes

File "nncf/nncf/quantization/algorithms/pipeline.py", line 119, in
run_step
current_model = pipeline_step[-1].apply(current_model, current_graph,
step_statistics)
IndexError: list index out of range

### Related tickets

N/A

### Tests

N/A
### Changes

as stated in the title

### Reason for changes

Follow-up from comment
openvinotoolkit#2218 (comment)

### Related tickets

n/a

### Tests

test_fn_max
test_fn_min
test_max
test_min
openvinotoolkit#2228)

### Changes

[PTQ] Avg pool is added as ignored metatype for TRANSFORMER model_type
in TORCH/OV/ONNX backends

### Reason for changes

* To align PTQ backends as for example TORCH avg_pool is mapping to
reduce_mean in OV, for timm/visformer_small in particular

### Related tickets

110985
119910

### Tests
### Changes
Pylint was removed from the make targets and from code. Added `.pylintrc` to `.gitignore` so that developers could have their own `.pylintrc` if they still want to use pylint in informational capacity locally.

### Reason for changes
Following through with the decision to use ruff as the main linter. Most of the pylint rules not covered by ruff will be covered by mypy in the future.

### Related tickets
N/A

### Tests
Existing test scope
### Changes
As stated in the title

### Reason for changes
Keeping up with the latest torch version

### Related tickets
N/A

### Tests
Existing torch test scope
…h visualization (openvinotoolkit#2231)

### Changes

Visualization of debug graph is fixed by replacing : to ^

### Reason for changes

To fix graph visualization for OV backend

### Related tickets


### Tests
### Changes

Add SE block ignored pattern for ONNX;

![image](https://github.com/openvinotoolkit/nncf/assets/32935044/edd1d9ad-3eb5-4f73-bc94-021c465b345a)

Add hsigmoid to OV SE block pattern

OV new quantization scheme for mobilentv3

![image](https://github.com/openvinotoolkit/nncf/assets/32935044/d089fda8-54c9-400f-9720-4957d2f077d5)
ONNX efficientnet-b0:

![image](https://github.com/openvinotoolkit/nncf/assets/32935044/c673cf55-03bb-49b0-971a-00c0e8e39420)
ONNX mobilentv3:

![image](https://github.com/openvinotoolkit/nncf/assets/32935044/e0dec26e-8607-4a2c-b889-7e250decb253)


### Reason for changes

Improve accuracy metrics for modes with SE block

### Related tickets

123692
123691

### Tests

Models from conformance test are tested manually
@ksilligan ksilligan merged commit fd79fce into develop Nov 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants