chore: Upgrade Golang version from 1.18 to 1.19 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @spolti -- could you separate the changes into 2 PRs -- without RHODS or CVE numbers in the title ;-)
|
|
Hi @ckadner, sure. |
spolti
force-pushed
the
CVE-2023-44487
branch
3 times, most recently
from
ccf4a0e
to
0defb5d
Compare
8 tasks
ckadner
changed the title
ckadner
changed the title
|
the CI issue will be fixed by #30 |
spolti
force-pushed
the
CVE-2023-44487
branch
2 times, most recently
from
76475fc
to
f2f6ca2
Compare
|
Thanks @ckadner, sry for the late reply, busy day. |
chore: Upgrade Go from 1.18 to 1.19 Plus: Fixes lint issues: - Can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte Warnings: WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. Signed-off-by: Spolti <[email protected]>
Signed-off-by: Spolti <[email protected]>
rafvasq
reviewed
Nov 23, 2023
There was a problem hiding this comment.
@ckadner, I tested this change too with no issues. Similar to kserve/modelmesh-runtime-adapter#68 (comment):
I deployed MM with your updates to this component and deployed/inferenced an inference service as outlined in the quickstart guide :)
Signed-off-by: Spolti <[email protected]>
spolti
force-pushed
the
CVE-2023-44487
branch
from
f2f6ca2
to
0780d31
Compare
Signed-off-by: Spolti <[email protected]>
spolti
force-pushed
the
CVE-2023-44487
branch
from
c4f0f0e
to
c66c7df
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ckadner, spolti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spolti
referenced
this pull request
in spolti/rest-proxy
Jan 10, 2024
- Remove the linters for "deadcode", "structcheck", "varcheck" - Use "os" packages instead of deprecated "io/ioutil" (SA1019) - Capture pre-commit output in a local log file --------- Signed-off-by: Spolti <[email protected]>
spolti
referenced
this pull request
in spolti/rest-proxy
Jan 10, 2024
- Remove the linters for "deadcode", "structcheck", "varcheck" - Use "os" packages instead of deprecated "io/ioutil" (SA1019) - Capture pre-commit output in a local log file --------- Signed-off-by: Spolti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed lint issues:
Warnings: