Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update x/ dependencies #67

Merged
merged 5 commits into from
Nov 21, 2023
Merged

chore: Update x/ dependencies #67

merged 5 commits into from
Nov 21, 2023

Conversation

Signed-off-by: Rafael Vasquez <[email protected]>
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafvasq -- instead of updating indirect dependencies, could you add those in a replace section with a comment hinting as to why.

e.g.: https://github.com/kserve/modelmesh-serving/blob/eb4bf296ff4667d064eb6d71362adf5427c8f3c3/go.mod#L129-L130

@rafvasq rafvasq requested a review from ckadner November 17, 2023 22:18
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit b61efb4 into kserve:main Nov 21, 2023
7 checks passed
@rafvasq rafvasq deleted the update-deps branch November 22, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants