chore: Ensure consistent version of generate proto stubs #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kadner <[email protected]>
ckadner
force-pushed
the
consistenly_generate_proto_stubs
branch
from
a3cacc7
to
10feca7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spolti
referenced
this pull request
in spolti/modelmesh-runtime-adapter
Jan 12, 2024
…-io#58) Ensure the versions of the generated protobuf code stubs are consistent with the versions as specified in the Dockerfile and the go.mo file. - protoc v3.21.5 - protoc-gen-go v1.28.1 - protoc-gen-go-grpc v1.3.0 Signed-off-by: Christian Kadner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The proto stubs can be generated either by using locally installed protoc CLI or by using the developer image which has all the required CLIs preinstalled.
However, the version of the generated code stubs varies based on the version of the CLIs used to generate them. In order to get consistent results, the developer image should install the same versions as specified in the
Dockerfileand thego.mo/go.sumfiles.Modifications
Update the Dockerfile to "install" the correct (specified) versions.
Result
The installed versions of protoc and its extensions matching the specified versions:
Dockerfile:ARG PROTOC_VERSION=21.5go.mod:google.golang.org/protobuf v1.28.1generated code: