Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update MLServer protobuf #45

Merged
merged 4 commits into from
May 26, 2023
Merged

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Apr 25, 2023

Motivation

Related to updating the MLServer runtime image, the ModelRepository endpoint was deprecated.

References:
kserve/modelmesh-serving#159
SeldonIO/MLServer#616

Modifications

  • Updated protobuf
  • Updated mock server testing
  • Updated runtime-adapter code to call new endpoint

Result

  • MLServer runtime adapter no longer uses the deprecated model repository API

Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq requested review from ckadner and removed request for joerunde April 26, 2023 13:12
Signed-off-by: Rafael Vasquez <[email protected]>
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq

Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, njhill, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit f9dc1dc into kserve:main May 26, 2023
@ckadner
Copy link
Member

ckadner commented May 26, 2023

Thanks @rafvasq

@rafvasq rafvasq deleted the update-mlserver branch May 26, 2023 15:00
ckadner pushed a commit to kserve/modelmesh-serving that referenced this pull request May 27, 2023
Update MLServer image for the default serving runtime from 0.5.2 to 1.3.2

Depends on kserve/modelmesh-runtime-adapter#45

Closes #357

Signed-off-by: Rafael Vasquez <[email protected]>
@ckadner ckadner added this to the v0.11.0 milestone Jun 2, 2023
@ckadner ckadner linked an issue Jun 2, 2023 that may be closed by this pull request
lgdeloss pushed a commit to lgdeloss/modelmesh-serving that referenced this pull request Jun 5, 2023
Update MLServer image for the default serving runtime from 0.5.2 to 1.3.2

Depends on kserve/modelmesh-runtime-adapter#45

Closes kserve#357

Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Luis Delossantos <[email protected]>
lgdeloss pushed a commit to lgdeloss/modelmesh-serving that referenced this pull request Jun 6, 2023
Update MLServer image for the default serving runtime from 0.5.2 to 1.3.2

Depends on kserve/modelmesh-runtime-adapter#45

Closes kserve#357

Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Luis Delossantos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MLServer serving runtime image
4 participants