Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add V2 Inference API support for OVMS runtime #31

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

njhill
Copy link
Member

@njhill njhill commented Aug 26, 2022

Motivation

Intel's OpenVINO Model Server has historically only supported the v1 (TFS) prediction API, but may also support v2 in upcoming versions.

Modifications

Adjust the built-in OVMS adapter to advertise the V2 gRPC Service APIs in addition to V1.

Result

KServe V2 Inference API will work with OVMS in ModelMesh Serving once supported by the OVMS container.

Motivation

Intel's OpenVINO Model Server has historically only supported the v1 (TFS) prediction API, but may also support v2 in upcoming versions.

Modifications

Adjust the built-in OVMS adapter to advertise the V2 gRPC Service APIs in addition to V1.

Result

KServe V2 Inference API will work with OVMS in ModelMesh Serving once supported by the OVMS container.

Signed-off-by: Nick Hill <[email protected]>
Copy link
Contributor

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Since I don't know how OVMS actually works, I will trust you have done the functional verification.

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chinhuang007, njhill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chinhuang007
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants