Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service に Streamlit アプリをデプロイする #17

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

ks6088ts
Copy link
Member

@ks6088ts ks6088ts commented Aug 2, 2024

What this PR does / why we need it

App Service のコードデプロイの手順に合わせるためアセットを一部変更。
デフォルト API key を環境変数で指定するようにしているが、フロントから参照できてしまうことに気付いたので一部修正。

7683730 add notes
7c5ef1b remove default value for API KEY
e77eeaf add deployment procedure for App Service

Which issue(s) this PR fixes:

Fixes #13

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [email protected]:ks6088ts-labs/workshop-azure-openai.git
cd workshop-azure-openai
  • Test the code
make ci-test

What to Check

Verify that the following are valid

  • ...

Additional Information

@ks6088ts ks6088ts self-assigned this Aug 2, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poetry.toml がマスター。重複管理になり避けたいが、App Service のデプロイでリポジトリルートに requirements.txt を配置することが前提になっているためやむなし。

@@ -15,7 +15,6 @@
)
azure_openai_api_key = st.text_input(
label="AZURE_OPENAI_API_KEY",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

フロントから API Key が参照できてしまうためデフォルト値をクリア。他も同じ。

@ks6088ts ks6088ts merged commit e6ba83f into main Aug 2, 2024
4 checks passed
@ks6088ts ks6088ts deleted the feature/issue-13_support-app-service branch August 2, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Service に Streamlit アプリをデプロイする
1 participant