Fixed parsing of extensions and nested types in swiftinterface files #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
till0xff
force-pushed
the
fix-swiftinterface-parsing
branch
from
f6a27a4
to
4e5a92e
Compare
till0xff
force-pushed
the
fix-swiftinterface-parsing
branch
from
4e5a92e
to
6fb0500
Compare
till0xff
changed the title
krzysztofzablocki
approved these changes
Nov 25, 2022
|
🙇 |
krzysztofzablocki
added a commit
that referenced
this pull request
Dec 7, 2022
|
@till0xff had to reverse part of it in 1.9.2 since it doesn't work properly, I added additional test that surfaces the issue with your implementation, happy to merge a new implementation that works with both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.