Update password reset email look #8
Conversation
| @@ -8,13 +8,21 @@ export const emailPasswordReset = ({ | |||
| }) => email({ | |||
| to, | |||
| from: '[email protected]', | |||
| subject: 'Password reset request', | |||
| subject: '[TurningPointTales] Please reset your password', | |||
There was a problem hiding this comment.
Want your opinion on the markup / copy here, and if there's anything
you'd word differently. I based this on a generalized group of reset password emails
from a couple sites.
There was a problem hiding this comment.
[nit] I'd say TurningPointTales: for a subject.
| } | ||
| </style> | ||
|
|
||
| <Form className="password-reset"> |
There was a problem hiding this comment.
I'll have to look into this later, but svelte does NOT like you doing this.
This is a react pattern that might not work the way I think it does in svelte.
It basically wipes away all the auto-generated classes on the element (which was causing this element to bounce around once you typed text).
| @@ -8,13 +8,21 @@ export const emailPasswordReset = ({ | |||
| }) => email({ | |||
| to, | |||
| from: '[email protected]', | |||
| subject: 'Password reset request', | |||
| subject: '[TurningPointTales] Please reset your password', | |||
There was a problem hiding this comment.
[nit] I'd say TurningPointTales: for a subject.
| You forgot your password, didn't you? A tale as old as time.<br/> | ||
| We're won't hold it against you. Forgive and forget.<br/> |
There was a problem hiding this comment.
s/'re//
s/Forgive and forget.// (too lengthy with everything else)
| } | ||
| </style> | ||
|
|
||
| <Form className="password-reset"> |
KristopherPaulsen
deleted the
update-password-reset-email-look-squashed
branch
* renaming and password reset fix * wrapping element for simpler resizing * give the user a route back to signin * tests for victory * Thats just a helper script * Speeling fixes
Testing:
Password-reset page elements should be vertically-horizontally centered, even after reseting password
(it was jumping around prior to this, eek!)
Login page should also be vertically / horizontally centered, and unaffected by this change
Emails should continue to be sent to the appropriate email address on password reset,
but now with better markup and copy.
Notes
I'm also moving around a couple things in the
storescategory. I'd really like stores that are basically our "svelte redux equivalent" or global app state to live in a specific folder, and obviously marked as global state. Otherwise all other stores are just objects and should live with everything else. Then, I could eventually create tooling to make it really easy for us to inspect the state of our app.