Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi tenant kubernetes example #510

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Multi tenant kubernetes example #510

merged 9 commits into from
Aug 8, 2023

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Aug 2, 2023 •
edited
Loading

Type of change

  • Enhancement / new feature

Description

(Revived from #481)
Simple kubernetes example showing multi-tenant in action. Kroxylicious exposed using NodePort.

The illustrative command used to demonstrate multitent use kaf. You could use any client,kaf just has a nice CLI experience.

Additional Context

Why are you making this pull request?

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
  • Make sure all Sonar-Lint warnings are addressed or are justifiably ignored.
  • Update documentation
  • Reference relevant issue(s) and close them after merging
  • For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

@k-wall k-wall changed the title Multi tenant example Multi tenant kubernetes example Aug 2, 2023
@k-wall k-wall requested review from SamBarker and robobario August 3, 2023 08:12
SamBarker
SamBarker approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing the connection to SNI is a good idea but I'm not entirely sold on the idea of passing the virtual cluster name via the context.

(n.b. I am aware that I did it first but there is a reason I didn't include it in the branch we merged adding the name to the model)

kroxylicious-api/src/main/java/io/kroxylicious/proxy/filter/KrpcFilterContext.java Show resolved Hide resolved
kubernetes-examples/multitenant/base/kroxylicious-config.yaml Show resolved Hide resolved
kubernetes-examples/multitenant/base/kroxylicious-config.yaml Show resolved Hide resolved
kubernetes-examples/multitenant/postinstall.sh Show resolved Hide resolved
kroxylicious/pom.xml Outdated Show resolved Hide resolved
@k-wall k-wall force-pushed the multi-tenant-example branch from 473a401 to 7922bec Compare August 4, 2023 07:59
@k-wall k-wall force-pushed the multi-tenant-example branch from 7922bec to a6effe9 Compare August 4, 2023 17:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 4 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@k-wall k-wall merged commit 1660c7d into kroxylicious:main Aug 8, 2023
@k-wall
Copy link
Contributor Author

k-wall commented Aug 8, 2023

Merged despite the Sonar Cloud gate. Justification:

@k-wall k-wall deleted the multi-tenant-example branch August 8, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamBarker SamBarker SamBarker approved these changes

@robobario robobario Awaiting requested review from robobario

Assignees
No one assigned
Labels
None yet
Projects
Kroxylicious
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-wall @robobario @SamBarker