Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding summary-always to the PR #269

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

franvila
Copy link
Contributor

Type of change

  • Enhancement / new feature

Description

Adding summary-always option to be able to upload a summary to the PR every time is called.

@franvila
Copy link
Contributor Author

/perf

@SamBarker
Copy link
Member

@franvila PR looks good, but I'm assuming your still testing something as its in draft. Feel free to ping for a review when your ready.

@franvila franvila marked this pull request as ready for review April 17, 2023 08:01
@franvila
Copy link
Contributor Author

@SamBarker yeap I was testing it. It is working pretty fine and it is easier to see the results right now:

Screenshot from 2023-04-17 10-36-56

@franvila franvila requested review from SamBarker and robobario April 17, 2023 08:41
Copy link
Member

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franvila franvila merged commit a10fa38 into kroxylicious:main Apr 17, 2023
@franvila franvila deleted the enhancePerfAction branch April 17, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants