test lift

[franvila]

Type of change

• Enhancement / new feature

Description

In order to have a build with no errors in Kroxylicious we would need to avoid java 19 jdk (integrationtests module) because there is no current support in Sonatype for that version. The LTS supported is JDK 17.

Additional Context

Why are you making this pull request?

[k-wall]

@franvila I clicked ready for review by mistake and couldn't find a way to switch it back.

[k-wall]

The only thing that I don't know how to skip is to avoid running ./mvnw by default when it is present in the project,

Looks like you could config what mvnw does by having your setup script create $HOME/.mavenrc (https://github.com/franvila/kproxy/blob/lift/mvnw#L43). I think you could use it to set MAVEN_CONFIG to -pl !:integrationtests --also-make-dependents.

[franvila]

@franvila I clicked ready for review by mistake and couldn't find a way to switch it back.

Once it is reviewed it cannot be switched back. This PR was intentionally created in draft to not merge it. The original one is that one from Sam, #242

[k-wall]

looks reasonable to me.

[franvila]

The only thing that I don't know how to skip is to avoid running ./mvnw by default when it is present in the project,

Looks like you could config what mvnw does by having your setup script create $HOME/.mavenrc (https://github.com/franvila/kproxy/blob/lift/mvnw#L43). I think you could use it to set MAVEN_CONFIG to -pl !:integrationtests --also-make-dependents.

@k-wall tested but it does not work. It seems setup and ./mvnw are executed in parallel so they are not always executed in the same order and does not affect the other.

[k-wall]

How about ignoring mvnw files in our tree with a ignoreFiles config setting? Like this:

https://community.sonatype.com/t/dependency-tab-using-maven-should-be-gradle/10323/3?u=kwall

[franvila]

@k-wall @SamBarker My intention was not to merge this PR, but if you agree we can merge this PR and close Sam's #242

[franvila]

How about ignoring mvnw files in our tree with a ignoreFiles config setting? Like this:

https://community.sonatype.com/t/dependency-tab-using-maven-should-be-gradle/10323/3?u=kwall

I tried that as well, but nothing. It seems it is configured by default to detect mvnw files and .lift.toml and execute the process in parallel if they files are found, without ignoring any of those if the other is found.

Anyway, it is "only" noise, non time consuming as they are executed in parallel, we just need one compilation to be able to run the static analysis.

[k-wall]

How about ignoring mvnw files in our tree with a ignoreFiles config setting? Like this:
https://community.sonatype.com/t/dependency-tab-using-maven-should-be-gradle/10323/3?u=kwall

I tried that as well, but nothing. It seems it is configured by default to detect mvnw files and .lift.toml and execute the process in parallel if they files are found, without ignoring any of those if the other is found.

Anyway, it is "only" noise, non time consuming as they are executed in parallel, we just need one compilation to be able to run the static analysis.

You are right, it probably doesn't matter as the build is reasonable quick. I suppose setup script could run.

rm -f mvnw*

[franvila]

rm -f mvnw*

Tested in this commit with no luck https://lift.sonatype.com/results/github.com/kroxylicious/kroxylicious/01GWVQP2KNRBCHQN9YMXRVYE55/?ph=PhaseIntroduced&tab=logs.

As I suspected, both processes are run in parallel without knowing each other, so no matter what the setup does, if mvnw exists at the beginning it will be launched by default.

[k-wall]

Please remember to squash and give it a sensible commit message