Make ClusterNetworkAddressConfigProvider and co internal #1394
Conversation
robobario
force-pushed
the
move-cnacp-and-friends
branch
from
b8ef2c3 to
3099fd0
Compare
There was a problem hiding this comment.
sonar doesn't like the ipv6 regex
Make sure the regex used here, which is vulnerable to polynomial runtime due to backtracking, cannot lead to denial of service.
Maybe we should merge this with a suppress and make an issue to follow up.
There was a problem hiding this comment.
Do we actually need a follow up issue? We are sure that we want an IPv6 address and that its not exposed to arbitrary input only that from the config file so I'm happy to merge with a suppression and nothing else.
There was a problem hiding this comment.
Do we actually need a follow up issue? We are sure that we want an IPv6 address and that its not exposed to arbitrary input only that from the config file so I'm happy to merge with a suppression and nothing else.
These interfaces may become a supported pluggable interface one day, but for now we want to reduce the API surface area we need to support. They have been deprecated long enough that we can make the breaking change required as per our deprecation policy. Signed-off-by: Robert Young <[email protected]>
robobario
force-pushed
the
move-cnacp-and-friends
branch
from
3099fd0 to
0dd4261
Compare
|
Type of change
Description
Closes #1381
These interfaces may become a supported pluggable interface one day, but for now we want to reduce the API surface area we need to support. They have been deprecated long enough that we can make the breaking change required as per our deprecation policy.
Checklist
Please go through this checklist and make sure all applicable tasks have been done