Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "old docs" warning messages to previous release docs pages #81

Merged

Conversation

gracegrimwood
Copy link
Contributor

The docs pages for versions up to and including v0.5.0 have a message at the top which reads This documentation is for an older release of Kroxylicious, and may not reflect current functionality. This message is missing from the docs for v0.5.1, v0.6.0, and v0.7.0 (v0.8.0 is the current release so shouldn't have this message), so this PR is just to add that missing message to those pages.

Copy link
Member

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'd really appreciated that adding the warning was a manual process.

LGTM

@gracegrimwood gracegrimwood merged commit f97af77 into kroxylicious:main Nov 6, 2024
1 check passed
@k-wall
Copy link
Contributor

k-wall commented Nov 11, 2024

I don't think I'd really appreciated that adding the warning was a manual process.

Me neither. As a minimum, we should document that we need to add 'old docs' to the previous release when releasing a new one. Ideally, it should be automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants