Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SegmentedControl)!: new Style and add icon #995

Merged
merged 10 commits into from
Sep 30, 2024
Merged

feat(SegmentedControl)!: new Style and add icon #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
da4add6
feat(SegmentedControl)!: new Style and add icon
LarryMatte Sep 19, 2024
0dad099
feat(SegmentedControl)!: fix lint
LarryMatte Sep 19, 2024
ccb4ae6
feat(SegmentedControl)!: fix lint
LarryMatte Sep 19, 2024
7bce943
feat(SegmentedControl)!: fix lint
LarryMatte Sep 19, 2024
2c20784
feat(SegmentedControl)!: fix savuts comments
LarryMatte Sep 19, 2024
87f6063
feat(SegmentedControl)!: fix savuts comments replace ariaDisabled
LarryMatte Sep 20, 2024
d078759
feat(SegmentedControl)!: add test
LarryMatte Sep 20, 2024
0048648
feat(SegmentedControl)!: fix marcs comment
LarryMatte Sep 23, 2024
8f6b146
feat(SegmentedControl)!: fix doc
LarryMatte Sep 24, 2024
d092316
feat(SegmentedControl)!: fix comment Max
LarryMatte Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/react/src/components/segmented-control/segmented-control.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { SegmentedControl } from './segmented-control';
const buttonGroup = [
{ label: 'Option 1', value: 'option1' },
{ label: 'Option 2', value: 'option2', defaultPressed: true },
{ label: 'Option 3', value: 'option3' },
{ label: 'Option 3', value: 'option3', disabled: true },
{ label: 'Option 4', value: 'option4' },
];

Expand All @@ -25,6 +25,20 @@ describe('SegmentedControl', () => {
expect(getByTestId(wrapper, 'test-toggle-button-1').prop('pressed')).toBe(true);
});

test('should have aria-pressed="true" for the default pressed button', () => {
const wrapper = shallow(<SegmentedControl buttonGroup={buttonGroup} groupName="Test2" />);
const button = getByTestId(wrapper, 'test-toggle-button-1');

expect(button.prop('aria-pressed')).toBe(true);
});

test('should have aria-disabled="true" for disabled button', () => {
const wrapper = shallow(<SegmentedControl buttonGroup={buttonGroup} groupName="Test" />);
const button = getByTestId(wrapper, 'test-toggle-button-2');

expect(button.prop('aria-disabled')).toBe(true);
});

test('Matches snapshot (desktop)', () => {
const tree = renderWithProviders(
<SegmentedControl buttonGroup={buttonGroup} groupName="Test4" />,
Expand Down
Loading