Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SectionalBanner)!: fix html and less restrictive usage #988

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(SectionalBanner)!: fix html and less restrictive usage #988

merged 1 commit into from
Sep 10, 2024

Conversation

savutsang
Copy link
Contributor

Changes

  • Remove a11y attributes related to notification.
  • Title is optional for all SectionalBanner types.
  • Allow custom Title text for all SectionalBanner types.
  • Dismiss is allowed and optional for all SectionalBanner types.

BREAKING CHANGES:

  • headingTag props don't accept "span" value anymore

@savutsang savutsang requested a review from a team as a code owner September 9, 2024 18:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Storybook for this build: https://ds.equisoft.io/pr-988/

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Webapp for this build: https://ds.equisoft.io/pr-988/webapp/

LarryMatte
LarryMatte approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@LarryMatte LarryMatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good pour moi. Je laisse Maxime faire sa passe pour l'approval final

pylafleur
pylafleur reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@pylafleur pylafleur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est ok pour le code , mais il faudrait revoir la doc pour le type alert vu qu'on mentionne qu'elle ne peut pas être dismissed.

J'avais pas vu l'autre PR pour la doc, j'ai transféré le commentaire.

@savutsang savutsang merged commit 9a8b3fc into master Sep 10, 2024
22 checks passed
@savutsang savutsang deleted the dev/DS-1099 branch September 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbrillant alexbrillant alexbrillant approved these changes

@LarryMatte LarryMatte LarryMatte approved these changes

@pylafleur pylafleur pylafleur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savutsang @pylafleur @LarryMatte @alexbrillant