chore(design-tokens): link alias tokens to component tokens #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Tous les problèmes soulevés dans les discussions ont été adressés! Je crois qu'on est proche du green light! 🟢 |
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
LarryMatte
approved these changes
Jun 7, 2024
| /** | ||
| * Use for backgrounds of elements in an empty state, | ||
| * such as carousel dots, progress elements, etc. | ||
| */ | ||
| 'color-bg-empty': 'color-neutral-15', | ||
| 'color-background-empty': 'color-neutral-15', | ||
| /** | ||
| * Use for the background of elements in a selected state, | ||
| * such as naviaation elements like pagination pages or items like table rows. |
There was a problem hiding this comment.
petit detail mais il y a une typo dans navigation: * such as naviaation elements like pagination pages or items like table rows.
|
@meriouma @pylafleur @savutsang Je crois que nous serions good, si l'un d'entre vous pouvait faire une passe, nous pourrions merger et avancer vers de nouvelles aventures. |
meriouma
approved these changes
Jun 7, 2024
packages/react/src/components/toggle-button-group/toggle-button-group.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-1120
Description
Ici on vient assigner les alias tokens à tous les component tokens.
Tests fonctionnels
Travail en collaboration avec @maboilard