Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(global banner): title on single line #822

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix(global banner): title on single line #822

merged 3 commits into from
Apr 24, 2024

Conversation

LarryMatte
Copy link
Contributor

@LarryMatte LarryMatte commented Apr 16, 2024

DS-1106

  • Titre de la banner sur une ligne et texte sur une autre ligne
  • ajouter un aria-labelledby="[id du title] sur la section qui wrap le content

@LarryMatte LarryMatte requested a review from a team as a code owner April 16, 2024 19:54
Copy link

Storybook for this build: https://ds.equisoft.io/pr-822/

Copy link

@maboilard maboilard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très sharp! Par contre, dans la story il y a les variantes Neutral et Default qui semble être pas mal la même chose. Peut-on supprimer la Default?

maboilard
maboilard previously approved these changes Apr 18, 2024
@LarryMatte
Copy link
Contributor Author

Très sharp! Par contre, dans la story il y a les variantes Neutral et Default qui semble être pas mal la même chose. Peut-on supprimer la Default?

@maboilard on va enlever la variante default dans une autre PR. Je préfère que nous gardions les PR en lien avec la tâche décrite dans la carte Jira.

@LarryMatte LarryMatte merged commit 08af5fa into master Apr 24, 2024
20 checks passed
@LarryMatte LarryMatte deleted the dev/DS-1106 branch April 24, 2024 19:47
pylafleur pushed a commit that referenced this pull request Jun 3, 2024
* fix(global banner): title on single line

* fix(global banner): fix savuts comments

* fix(global banner): ajout tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants