feat(table)!: expandable rows #759

savutsang · 2024-03-04T15:29:18Z

DS-914

Description:

Support single or multiple rows expansion.
Support subrows (child rows with the same columns)
Support content row to display custom content.
Can have a mix of expandable and not expandable rows within the same table.

Fixes:

Table headers were always sortable because of a bad check.

BREAKING CHANGE:

TableColumn<T> is now an interface of one column instead of the whole array.

github-actions · 2024-03-04T20:51:16Z

Storybook for this build: https://ds.equisoft.io/pr-759/

LarryMatte

1ere passe de fait.
Quelques petites modifications à apporter au button qui trigger l'expand et questions ici et là.
Sinon, il y a un petit glitch quand une row expand, le texte de toute la table bouge de gauche à droite.

Screen.Recording.2024-03-06.at.10.47.36.AM.mov

packages/react/src/components/table/table.tsx

packages/storybook/stories/table.stories.tsx

…-elements into dev/DS-914

…technologies/design-elements into dev/DS-914

savutsang · 2024-04-12T19:47:49Z

Sinon, il y a un petit glitch quand une row expand, le texte de toute la table bouge de gauche à droite.

Tel que discute avec les designers, on enleve l'indentation.

…-elements into dev/DS-914

savutsang · 2024-04-15T17:44:40Z

Pret pour review, tout a ete corrige

LarryMatte

un petit details mais sinon GJ !

packages/react/src/components/table/table.tsx

packages/react/src/components/table/types.ts

maboilard

Dans la story Expandable Sub Content, lorsque la rangée est expanded, il manque le séparateur entre la rangée et le sub content. Aussi, celui-ci devrait être aligné avec la colonne de texte et non pas le caret. À part ça, ça semble bien good pour moi! :)

savutsang · 2024-04-19T15:53:30Z

Dans la story Expandable Sub Content, lorsque la rangée est expanded, il manque le séparateur entre la rangée et le sub content. Aussi, celui-ci devrait être aligné avec la colonne de texte et non pas le caret. À part ça, ça semble bien good pour moi!

C'est fixe

maboilard · 2024-04-19T16:07:28Z

Dans la story Expandable Sub Content, lorsque la rangée est expanded, il manque le séparateur entre la rangée et le sub content. Aussi, celui-ci devrait être aligné avec la colonne de texte et non pas le caret. À part ça, ça semble bien good pour moi!

C'est fixe

Mmm, pourtant, ça me donne toujours ceci:

Est-ce normal?

…-elements into dev/DS-914

savutsang · 2024-04-19T17:48:04Z

Mmm, pourtant, ça me donne toujours ceci

Ca n'avait pas deploye comme il faut, c'est bon maintenant.

maboilard

All good pour moi. Beau boulot!

savutsang · 2024-04-22T12:45:29Z

Tous les commentaires ont ete resolved, pret pour review.

* feat(table): expandable rows * fix: accessibility and subrows * fix: tests * fix: story * fix: force deploy storybook * fix: post comments * fix: comments * fix: remove condition from cell render

savutsang requested a review from a team as a code owner March 4, 2024 15:29

feat(table): expandable rows

e9af444

savutsang force-pushed the dev/DS-914 branch from b4f97dc to e9af444 Compare March 4, 2024 20:47

savutsang temporarily deployed to github-pages March 4, 2024 20:50 — with GitHub Actions Inactive

LarryMatte requested changes Mar 6, 2024

View reviewed changes

Merge branch 'master' of https://github.com/kronostechnologies/design…

f5fded8

…-elements into dev/DS-914

savutsang temporarily deployed to github-pages March 28, 2024 19:09 — with GitHub Actions Inactive

Merge branches 'dev/DS-914' and 'master' of https://github.com/kronos…

f0683af

…technologies/design-elements into dev/DS-914

savutsang temporarily deployed to github-pages April 5, 2024 17:46 — with GitHub Actions Inactive

savutsang added 2 commits April 12, 2024 15:02

fix: accessibility and subrows

77c4fb6

fix: tests

bfbab19

savutsang temporarily deployed to github-pages April 12, 2024 19:23 — with GitHub Actions Inactive

savutsang changed the title ~~feat(table): expandable rows~~ feat(table)!: expandable rows Apr 12, 2024

fix: story

29f372c

savutsang temporarily deployed to github-pages April 12, 2024 19:50 — with GitHub Actions Inactive

savutsang added 2 commits April 12, 2024 15:55

fix: force deploy storybook

99aa27e

Merge branch 'master' of https://github.com/kronostechnologies/design…

caf8144

…-elements into dev/DS-914

savutsang temporarily deployed to github-pages April 12, 2024 19:59 — with GitHub Actions Inactive

Merge branch 'master' into dev/DS-914

cc63722

savutsang temporarily deployed to github-pages April 15, 2024 17:42 — with GitHub Actions Inactive

savutsang requested a review from LarryMatte April 15, 2024 17:45

LarryMatte requested changes Apr 15, 2024

View reviewed changes

packages/react/src/components/table/table.tsx Show resolved Hide resolved

meriouma reviewed Apr 15, 2024

View reviewed changes

maboilard requested changes Apr 16, 2024

View reviewed changes

fix: post comments

13b6eff

savutsang added 2 commits April 19, 2024 13:23

Merge branch 'master' of https://github.com/kronostechnologies/design…

3ba8f50

…-elements into dev/DS-914

fix: comments

f1a66da

savutsang temporarily deployed to github-pages April 19, 2024 17:29 — with GitHub Actions Inactive

maboilard previously approved these changes Apr 19, 2024

View reviewed changes

savutsang dismissed maboilard’s stale review via 9148bf2 April 19, 2024 18:12

savutsang temporarily deployed to github-pages April 19, 2024 18:16 — with GitHub Actions Inactive

fix: remove condition from cell render

3a2ed4c

savutsang force-pushed the dev/DS-914 branch from 9148bf2 to 3a2ed4c Compare April 22, 2024 12:39

savutsang temporarily deployed to github-pages April 22, 2024 12:43 — with GitHub Actions Inactive

maboilard approved these changes Apr 22, 2024

View reviewed changes

meriouma approved these changes Apr 24, 2024

View reviewed changes

LarryMatte approved these changes Apr 24, 2024

View reviewed changes

savutsang merged commit 80006c1 into master Apr 24, 2024
20 checks passed

savutsang deleted the dev/DS-914 branch April 24, 2024 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(table)!: expandable rows #759

feat(table)!: expandable rows #759

savutsang commented Mar 4, 2024 •

edited

Loading

github-actions bot commented Mar 4, 2024

LarryMatte left a comment

savutsang commented Apr 12, 2024 •

edited

Loading

savutsang commented Apr 15, 2024 •

edited

Loading

LarryMatte left a comment

maboilard left a comment •

edited

Loading

savutsang commented Apr 19, 2024

maboilard commented Apr 19, 2024

savutsang commented Apr 19, 2024

maboilard left a comment

savutsang commented Apr 22, 2024

feat(table)!: expandable rows #759

feat(table)!: expandable rows #759

Conversation

savutsang commented Mar 4, 2024 • edited Loading

github-actions bot commented Mar 4, 2024

LarryMatte left a comment

Choose a reason for hiding this comment

savutsang commented Apr 12, 2024 • edited Loading

savutsang commented Apr 15, 2024 • edited Loading

LarryMatte left a comment

Choose a reason for hiding this comment

maboilard left a comment • edited Loading

Choose a reason for hiding this comment

savutsang commented Apr 19, 2024

maboilard commented Apr 19, 2024

savutsang commented Apr 19, 2024

maboilard left a comment

Choose a reason for hiding this comment

savutsang commented Apr 22, 2024

savutsang commented Mar 4, 2024 •

edited

Loading

savutsang commented Apr 12, 2024 •

edited

Loading

savutsang commented Apr 15, 2024 •

edited

Loading

maboilard left a comment •

edited

Loading