feat(tag, theme)!: update colored tag variant #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Storybook for this build: https://ds.equisoft.io/pr-758/ |
savutsang
reviewed
Mar 4, 2024
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
savutsang
reviewed
Mar 4, 2024
savutsang
reviewed
Mar 4, 2024
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
maboilard
reviewed
Mar 8, 2024
There was a problem hiding this comment.
C'est peut-être hors scope mais est-ce que les border-radius sont vraiment de 6px? Quand je compare avec Pixel Perfect, ils semblent plus prononcés ici.
À part de ça, je n'ai pas d'autres commentaires à part qu'il manque Violet et Magenta dans DefaultTagColor
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Mmhmm le référencement vers le bon typing avec les controls de storybook ne se font plus... |
meriouma
reviewed
Apr 16, 2024
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
meriouma
reviewed
Apr 16, 2024
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
C'est embêtant, parce que sur toutes les PRs de Pierre-Yves ça fonctionne encore 🤔 |
meriouma
reviewed
Apr 16, 2024
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
meriouma
reviewed
Apr 24, 2024
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
meriouma
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-948
Description
Ici on vient ajouter les variantes de couleurs de la composante
Taget on vient également mettre à jour quelques détails par rapport aux maquettes Figma de l'équipe design.Les variantes de couleurs ne supportent pas certaines fonctionnalités pour le moment:
De plus, on vient ajouter le package
@storybook/addon-controlsqui permet de tester au runtime différentes variables sur la composante. Très intéressant pour le futur du storybook!En extra, il y aura une concaténation si la chaîne de caractère pour le label/extraLabel dépasse les 20 charactères. (Suivant les guidelines du Notion sur les tags)
Tests fonctionnels
Screenshots