-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(global-banner, theme)!: update variants #751
Conversation
Storybook for this build: https://ds.equisoft.io/pr-751/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meriouma l'a mentionne dans un PR precedent, ceci doit etre identifie comme un breaking change puisqu'on a change les valeurs des props publiques. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Petits questionnements/suggestions, sinon LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Petit détails, sinon LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, juste un alignement à corriger!
DS-1003
Description
Ici on vient mettre à jour les variantes de Global Banner par rapport aux maquettes Figma de l'équipe design.
Tests fonctionnels
Screenshots