Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(global-banner, theme)!: update variants #751

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Conversation

hebernardEquisoft
Copy link
Contributor

@hebernardEquisoft hebernardEquisoft commented Feb 29, 2024

DS-1003

Description

Ici on vient mettre à jour les variantes de Global Banner par rapport aux maquettes Figma de l'équipe design.

Tests fonctionnels

  • Valider le bon fonctionnement des global banners
  • Valider minutieusement le bon theming de chacune des variantes de global banner par rapport aux maquettes

Screenshots

image

Copy link

Storybook for this build: https://ds.equisoft.io/pr-751/

Copy link

@maboilard maboilard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La couleur du bouton au hover est différente de celui du Toast, ce qui ne devrait pas être le cas. Il faudrait donc changer la couleur pour qu'elle soit uniforme au Toast.
image

@savutsang
Copy link
Contributor

savutsang commented Mar 12, 2024

@meriouma l'a mentionne dans un PR precedent, ceci doit etre identifie comme un breaking change puisqu'on a change les valeurs des props publiques.

@hebernardEquisoft hebernardEquisoft changed the title chore(global-banner, theme): update variants feat(global-banner, theme)!: update variants Mar 12, 2024
Copy link
Contributor

@meriouma meriouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petits questionnements/suggestions, sinon LGTM.

maboilard
maboilard previously approved these changes Mar 18, 2024
Copy link

@maboilard maboilard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

Copy link
Contributor

@meriouma meriouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit détails, sinon LGTM!

Copy link
Contributor

@pylafleur pylafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, juste un alignement à corriger!

@hebernardEquisoft hebernardEquisoft merged commit 4394b08 into master Mar 19, 2024
20 checks passed
@hebernardEquisoft hebernardEquisoft deleted the dev/DS-1003 branch March 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants