chore(deps)!: update react-table to v8 #707

savutsang · 2024-01-22T19:33:29Z

Start the PR fresh but I had kept all the commits (previously #682)

React-Table V8 is pretty much a whole refactoring and has a lot of breaking changes from the previous version (including the columns definition).
https://tanstack.com/table/v8/docs/guide/migrating

BREAKING CHANGES

Sorting on multiple columns is not possible anymore (was build-in and enabled previously).
Columns definition:
- accessor was renamed to accessorKey.
- Header was renamed to header.
- Footer was renamed to footer.
- Cell was renamed to cell.
- All disable* column options were renamed to enable* column options.

Others fixes:

I have added an Table/Optimization section in the Storybook to explain how to use react-table correctly.
Removed defaultSort in columns, added defaultSort in Table props instead. The reason is the previous format is not great because if the dev use it in multiple columns, you don't know which one to sort, and even if you support multisort, you don't know the order (which columns are sorted first).
ESLint indent was disabled for tsx, I don't really know why but I was not able to make it use 4 spaces. Anyway this is going obsolete soon (replaced by https://eslint.style)
Fix the Table CSS to work with Styled-Component v6 (https://styled-components.com/docs/faqs#nested-syntax-handling)
Remove the shadow on the footer borders.

…-elements into dev/DS-936-update-react-data-table

github-actions · 2024-01-22T20:51:34Z

Storybook for this build: https://ds.equisoft.io/pr-707/

packages/react/src/components/table/table.test.tsx.snap

* feat(Table): add headerAriaLabel prop * feat(Table): add aria label on header column def type * fix: tests * feat(Table): add aria-label warning for headers without text * feat(Table): fix header aria-label warning * feat(Table): fix eslint in table-header * feat(Table): use warn instead of error for aria label warning * feat(Table): fix storybook for header aria label --------- Co-authored-by: Savut Sang <[email protected]>

* feat(Table): manual sorting * fix: comments

…-elements into dev/DS-936-update-react-table

pylafleur

Je peux pas promettre que j'ai tout analysé en détail mais ça me semble bon fonctionnellement!

meriouma

2 petits commentaires sinon LGTM! Et est-ce que tu pourrais documenter un peu plus ce qui est breaking comme changements dans nos interfaces, surtout pour la définition de colonnes? Ça me faciliterait un petit peu la vie quand je vais faire la release ;)

packages/storybook/stories/table.stories.tsx

savutsang · 2024-02-14T00:18:18Z

Et est-ce que tu pourrais documenter un peu plus ce qui est breaking comme changements dans nos interfaces, surtout pour la définition de colonnes?

J'ai update le PR avec une section BREAKING CHANGES.

meriouma · 2024-02-14T18:42:34Z

packages/react/src/components/table/table-header.tsx

+    }
+    if (currentSort === 'desc') {


Ça pourrait être un else if

carlafranca and others added 24 commits December 7, 2023 15:17

fix(deps): update dependency react-table

1d15553

fix: update export

4eeaa16

fix: create file for table footer

43366aa

fix: create file for table header

81fcf6f

fix: update rows with new implementation

12fecec

fix: update table with new table version

f2d0d60

fix: update stories with new version

0b22987

fix: update tests

9244f5e

fix: removed unused files

ef274de

fix: merge branch 'master'

b69498d

fix: typing and formatting

2752321

fix: formatting problem

88e00a7

Merge branch 'master' of https://github.com/kronostechnologies/design…

fe259fb

…-elements into dev/DS-936-update-react-data-table

fix: sticky footer not working

57f54ba

fix: sortable headers has wrong styles

6e8ef6c

fix: lint and tests

7130abd

Merge branch 'master' of https://github.com/kronostechnologies/design…

cd9c432

…-elements into dev/DS-936-update-react-data-table

Merge branch 'master' of https://github.com/kronostechnologies/design…

b57aa6c

…-elements into dev/DS-936-update-react-data-table

fix: initial sorting

9583232

fix: compatible SC6

e022ba8

fix: remove defaultSort from column

03d761b

chore: add table optimization example

7931693

chore: update storybook description

3d0f5e3

Merge branch 'master' of https://github.com/kronostechnologies/design…

46781ed

…-elements into dev/DS-936-update-react-data-table

savutsang requested a review from a team as a code owner January 22, 2024 19:33

savutsang temporarily deployed to github-pages January 22, 2024 20:51 — with GitHub Actions Inactive

chore: doc

394d4c3

savutsang force-pushed the dev/DS-936-update-react-table branch from 3eb36fe to 394d4c3 Compare January 22, 2024 21:03

chore: simplidy table example code

8e997b8

fix: snapshot

e6fbca2

savutsang temporarily deployed to github-pages January 31, 2024 18:36 — with GitHub Actions Inactive

Merge branch 'master' into dev/DS-936-update-react-table

6ac1c81

savutsang temporarily deployed to github-pages January 31, 2024 19:31 — with GitHub Actions Inactive

savutsang commented Feb 2, 2024

View reviewed changes

packages/react/src/components/table/table.test.tsx.snap Show resolved Hide resolved

alexbrillant and others added 3 commits February 2, 2024 16:16

fix: remove extra scrollbars in stories

537864b

fix: remove extra background in snapshots

64c6d68

savutsang temporarily deployed to github-pages February 2, 2024 21:36 — with GitHub Actions Inactive

savutsang and others added 2 commits February 5, 2024 09:55

feat(Table): manual sorting (#719)

dc39f0a

* feat(Table): manual sorting * fix: comments

fix: rename props

8e9ddac

savutsang force-pushed the dev/DS-936-update-react-table branch from 0602db5 to 6b8c56a Compare February 5, 2024 16:29

Merge branch 'master' of https://github.com/kronostechnologies/design…

89267c9

…-elements into dev/DS-936-update-react-table

savutsang force-pushed the dev/DS-936-update-react-table branch from 6b8c56a to 89267c9 Compare February 5, 2024 16:44

savutsang temporarily deployed to github-pages February 5, 2024 16:48 — with GitHub Actions Inactive

fix: use max-height in stories

067fb7c

savutsang temporarily deployed to github-pages February 5, 2024 18:34 — with GitHub Actions Inactive

pylafleur previously approved these changes Feb 12, 2024

View reviewed changes

meriouma reviewed Feb 12, 2024

View reviewed changes

packages/storybook/stories/table.stories.tsx Outdated Show resolved Hide resolved

packages/storybook/stories/table.stories.tsx Outdated Show resolved Hide resolved

savutsang dismissed pylafleur’s stale review via 3a148ed February 14, 2024 00:09

fix: stories

0fef1f3

savutsang temporarily deployed to github-pages February 14, 2024 00:13 — with GitHub Actions Inactive

savutsang force-pushed the dev/DS-936-update-react-table branch from edde2d1 to 0fef1f3 Compare February 14, 2024 00:20

Merge branch 'master' into dev/DS-936-update-react-table

ac6e71c

savutsang temporarily deployed to github-pages February 14, 2024 00:24 — with GitHub Actions Inactive

savutsang enabled auto-merge (squash) February 14, 2024 00:27

meriouma approved these changes Feb 14, 2024

View reviewed changes

savutsang merged commit 73dc3d0 into master Feb 14, 2024
20 checks passed

savutsang deleted the dev/DS-936-update-react-table branch February 14, 2024 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps)!: update react-table to v8 #707

chore(deps)!: update react-table to v8 #707

savutsang commented Jan 22, 2024 •

edited

Loading

github-actions bot commented Jan 22, 2024

pylafleur left a comment

meriouma left a comment •

edited

Loading

savutsang commented Feb 14, 2024 •

edited

Loading

meriouma Feb 14, 2024

chore(deps)!: update react-table to v8 #707

chore(deps)!: update react-table to v8 #707

Conversation

savutsang commented Jan 22, 2024 • edited Loading

github-actions bot commented Jan 22, 2024

pylafleur left a comment

Choose a reason for hiding this comment

meriouma left a comment • edited Loading

Choose a reason for hiding this comment

savutsang commented Feb 14, 2024 • edited Loading

meriouma Feb 14, 2024

Choose a reason for hiding this comment

savutsang commented Jan 22, 2024 •

edited

Loading

meriouma left a comment •

edited

Loading

savutsang commented Feb 14, 2024 •

edited

Loading