Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nightly features for no_std #58

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

domenukk
Copy link
Contributor

Starting with Rust 1.81, core::errors::Error landed in stable:
https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#coreerrorerror

core::net was already stabilized with 1.77.0.

This means we no longer need extra nightly features to build ipnet on no_std.

@domenukk
Copy link
Contributor Author

Any news? :)

@domenukk
Copy link
Contributor Author

@jjanowsk this would be useful to have in order to allow crates downstream to be no_std, see for example hickory-dns/hickory-dns#2104

@al8n
Copy link

al8n commented Jan 13, 2025

Hi, any updates on this PR? We also need the no_std to be compatible with the stable channel for downstream crates to support no_std.

@krisprice
Copy link
Owner

Hi @domenukk & @al8n - am I tripping, or could we just drop all uses of std::net::{IpAddr ...} and swap for core::net::{IpAddr ...} and likewise for Error throughout in that case?

@domenukk
Copy link
Contributor Author

Yeah that's totally right.

The reason to keep the std import around for a while would be to remain backwards compatible with earlier rust versions (so 1.81 no-std or earlier and std will work).

But yes.

@krisprice krisprice merged commit 32d0bf4 into krisprice:master Jan 20, 2025
@krisprice
Copy link
Owner

Thanks - I'll swap the imports sometime later - should be published now.

@domenukk
Copy link
Contributor Author

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants