Skip to content

Commit

Permalink
Fix librdkafka Envoy dependency builds
Browse files Browse the repository at this point in the history
New version of LLD coming with llvm-18 generates erros when building
librdkafka dependency on Envoy (see
confluentinc/librdkafka#4593).

While there is an upstream PR fixing the issue, it has not been
merged and even when it will be merged, Envoy release v1.32 will still
be stuck with an old version without this fix.

I'm working around this with a patch to Envoy codebase by disabling
the use of linker scripts in librdkafka builds alltogether, and as
a consequence disabling the issues that come from the symbols defined
in the linker script only.

Signed-off-by: Mikhail Krinkin <[email protected]>
  • Loading branch information
krinkinmu committed Jan 3, 2025
1 parent 3119d2a commit 3795b40
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bazel/foreign_cc/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ configure_make(
],
tags = ["skip_on_windows"],
targets = [
"ARFLAGS='' libs install-subdirs",
"ARFLAGS='' WITH_LDS='n' libs install-subdirs",
],
deps = [":lz4"],
alwayslink = True,
Expand Down

0 comments on commit 3795b40

Please sign in to comment.