Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature bootstrap3 #646

Closed
wants to merge 2 commits into from
Closed

Conversation

langpavel
Copy link
Collaborator

@koistya If you create a new branch feature/bootstrap3...

Please, don't squash commits, 0eba0fd is minimal needed to brink react-bootstrap alive.

</Navbar.Brand>
</Navbar.Header>
<Nav>
<NavItem eventKey={1} href="#">Link</NavItem>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@langpavel how do you get NavItem to act like a Link component? I have spent a bunch of time trying to change the UniversalRouter functionality to react-router just to get this working, but I have a feeling that there is a simpler solution. Thanks for your help!

Copy link
Collaborator Author

@langpavel langpavel Jul 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure now.. Try this, It can work:

  <NavItem componentClass={Link} eventKey={1} href="/link" to="/link">Link</NavItem>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! That worked perfectly.

Copy link

@james075 james075 Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@langpavel @rkait In my case using this: componentClass does not work, I can click on the navItem but nothing happens.

<Navbar.Collapse>
  <Nav pullRight>
    <NavItem 
      componentClass={Link} 
      href="/manifesto" 
      to="/manifesto" 
      className={s.link}
    > Manifesto </NavItem>
  </Nav>
</Navbar.Collapse>

It works when I simply use the Link component. Any ideas how to fix it? Thanks for your help!

@MikeCodeur
Copy link

MikeCodeur commented Jul 27, 2016

Hi all, If you use components/Html.js don't forget to patch it with

<link rel="stylesheet" href="/css/bootstrap.min.css" / >

@langpavel
Copy link
Collaborator Author

See #782 for Up to date version

@langpavel langpavel closed this Jul 31, 2016
@isaklafleur
Copy link

You can just add the bootstrap cdn link in the head of the index.html file in the public folder. That will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants