Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include correct userAgent in server for react server-side rendering #1301

Closed
wants to merge 1 commit into from

Conversation

jwchang0206
Copy link

This helps to have correct auto-prefixed server rendered page.

This helps to have correct auto-prefixed server rendered page.
@jwchang0206
Copy link
Author

This fix resolved these problems.

mui/material-ui#4437
mui/material-ui#6920
mui/material-ui#2336

@langpavel
Copy link
Collaborator

That way global.navigator.userAgent will not be stable on entire request lifecycle.
Because every new request will change global state, you can observe glitches if you make multiple parallel requests across different browsers.
This is really bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants