Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free __DEV__ variable provided by webpack should be used across RSK #1114

Merged
merged 5 commits into from
Feb 16, 2017
Merged

Free __DEV__ variable provided by webpack should be used across RSK #1114

merged 5 commits into from
Feb 16, 2017

Conversation

langpavel
Copy link
Collaborator

@langpavel langpavel commented Feb 2, 2017 •
edited
Loading

Rebase of #1088, Thanks @buildbreakdo.
Closes #1085 #1088.

@langpavel langpavel mentioned this pull request Feb 2, 2017
Closed
langpavel
langpavel commented Feb 2, 2017
View reviewed changes
Copy link
Collaborator Author

@langpavel langpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @koistya, @frenzzy? I'm recommending squash merge.

@langpavel langpavel requested review from koistya and frenzzy February 2, 2017 21:00
@frenzzy
Copy link
Member

frenzzy commented Feb 2, 2017

I think it's ok for entire app but not for local variable inside tools/webpack.config.js

@buildbreakdo
Copy link

buildbreakdo commented Feb 3, 2017 •
edited
Loading

@frenzzy What is the value add of two patterns? As understood __DEV__ is basically a reference to isDebug (not literally granted the build step), would think that we would go one way or another. We could use isDebug as the global define if preferred; used __DEV__ because of use in the main React repo and abnormal syntax (easy to spot).

@langpavel Thanks for squashing 👍 , made a mess of that pull request.

@langpavel
Copy link
Collaborator Author

@buildbreakdo: I agree with @frenzzy about tools/webpack.config.js. Everywhere else __DEV__ is handled by webpack except all in tools/.. Can you revert changes from webpack.config.js please?

@buildbreakdo
Copy link

buildbreakdo commented Feb 4, 2017 •
edited
Loading

@frenzzy @langpavel Okay, that's consensus. This has been reverted on the original fork. Thanks both of you for the feedback

@buildbreakdo
Copy link

@langpavel Anything I need to do?

@langpavel langpavel merged commit 4bc6f83 into kriasoft:master Feb 16, 2017
@langpavel
Copy link
Collaborator Author

Squashed and merged. Thanks @buildbreakdo.

JasonPierce pushed a commit to 2Toad/react-starter-kit that referenced this pull request Apr 18, 2017
@langpavel
Free __DEV__ variable provided by webpack should be used across RSK (k…
a756a08 
…riasoft#1114)

Free __DEV__ variable provided by webpack should be used across RSK instead of NODE_ENV checks
Thanks @buildbreakdo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koistya koistya Awaiting requested review from koistya

@frenzzy frenzzy Awaiting requested review from frenzzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langpavel @frenzzy @buildbreakdo