Update Webpack to v2.2.1; update other npm modules #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardya
reviewed
Feb 3, 2017
| const Admin = await new Promise((resolve) => { | ||
| require.ensure([], (require) => resolve(require('./Admin').default), 'admin'); | ||
| }); | ||
| const Admin = await require.ensure([], require => require('./Admin').default, 'admin'); |
There was a problem hiding this comment.
Is this preferred over system.import statement? Are they any different?
There was a problem hiding this comment.
based on #901
...waiting for chunk name solution before upgrading to webpack v2.
Is System.import in webpack v2 already support chunk name ?
There was a problem hiding this comment.
- Note on the deprecated
System.import: webpack's use ofSystem.importdidn't fit the proposed spec, so it was deprecated in v2.1.0-beta.28 in favor ofimport()- Caveat:
require.ensureallows for easy chunk naming with the optional third argument, butimportAPI doesn't offer that capability yet. If you want to keep that functionality, you can continue usingrequire.ensure.
So, if you don't care about chunk name you can just use import here
const Admin = await import('./Admin').default;
JasonPierce
pushed a commit
to 2Toad/react-starter-kit
that referenced
this pull request
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues #1093
also fixes #1047 #1021 #954