webpack config still references react-routing

[nuclearspike]

https://github.com/kriasoft/react-starter-kit/blob/master/tools/webpack.config.js#L52 (+ 2 more)

If everything works without having those paths be valid, do they really do anything?

[koistya]

It's considered to be a good practice to explicitly specify what
folders/files should be parsed by a Webpack loader.

On Wednesday, 27 July 2016, Paul [email protected] wrote:

https://github.com/kriasoft/react-starter-kit/blob/master/tools/webpack.config.js#L52
(+ 2 more)

If everything works without having those paths be valid, do they really do
anything?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#770, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAMCDlWXnTQ_3H083A1JePj6ZDmPps4qks5qZn40gaJpZM4JVngc
.

[nuclearspike]

But react-routing is not in the package anymore and should now be 'universal-router' which is what I changed those references to in the config.

[koistya]

Ah, right, need to remove that line.

On Wednesday, 27 July 2016, Paul [email protected] wrote:

But react-routing is not in the package anymore and should now be
'universal-router' which is what I changed those references to in the
config.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#770 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMCDnEQI1ttwqRSKHuZkzA2A6a6CuNYks5qZn_1gaJpZM4JVngc
.