Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 6to5 transform instead of ReactTools transform #53

Closed
dmnd opened this issue Jan 16, 2015 · 6 comments
Closed

Use 6to5 transform instead of ReactTools transform #53

dmnd opened this issue Jan 16, 2015 · 6 comments
Labels
enhancement help wanted

Comments

@dmnd
Copy link

dmnd commented Jan 16, 2015

6to5 handles JSX just fine, but it also gives a lot more ES6 features.
@koistya
Copy link
Member

koistya commented Jan 16, 2015

@dmnd, yep, good suggestion! Do you use 6to5 at Khan Academy? I'm wondering, if there are any known issues with it?

@dmnd
Copy link
Author

dmnd commented Jan 16, 2015

We don't use it at KA; we use ReactTools like you are.

But I'm doing a side project based off this repo and I ended up wanting more ES6. I have 6to5 running and it seems to work fine. My code isn't yet in a state to send you PRs, though I really should get to that.

@adowning
Copy link

+1 good suggestion

@sdiaz
Copy link

sdiaz commented Jan 21, 2015

6to5 and esnext has merged efforts : http://6to5.org/blog/2015/01/12/6to5-esnext/ so it's a good suggestion

@goatslacker
Copy link

I second this.

6to5 comes with some caveats if you're trying to support legacy browsers like IE8 and below, it seems like the caveats are outweighed by the goodness that 6to5 brings.

@goatslacker goatslacker mentioned this issue Feb 8, 2015
Closed
koistya added a commit that referenced this issue Feb 8, 2015
@koistya
Update server-side rendering logic and other misc stuff
9f49066 
 - Refactor webpack config
 - Generate source maps in debug mode
 - Create two bundles during a build - `./build/app.js` (client-side) and `./build/server.js` (server-side)
 - Replace the original JSX transpiler with 6to5
 - Register core-js polyfills
 - Clean up the top-level React component (App)
 - Load page content asynchronously
 - Remove `./src/images` folder and `images` Gulp task in favor of images-per-component

Closes #57, #55, #53,  #4
@koistya
Copy link
Member

koistya commented Feb 8, 2015

Just have replaced the original JSX transpiler with 6to5. See webpack.config.js

@koistya koistya closed this as completed Feb 8, 2015
vishwanatharondekar added a commit to vishwanatharondekar/react-starter-kit that referenced this issue Oct 16, 2015
@vishwanatharondekar
Update server-side rendering logic and other misc stuff
541a3cf 
 - Refactor webpack config
 - Generate source maps in debug mode
 - Create two bundles during a build - `./build/app.js` (client-side) and `./build/server.js` (server-side)
 - Replace the original JSX transpiler with 6to5
 - Register core-js polyfills
 - Clean up the top-level React component (App)
 - Load page content asynchronously
 - Remove `./src/images` folder and `images` Gulp task in favor of images-per-component

Closes kriasoft#57, kriasoft#55, kriasoft#53,  kriasoft#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 6to5 rather than jstransform goatslacker/react-starter-kit
5 participants
@dmnd @goatslacker @koistya @sdiaz @adowning