Remove params
parameter from exec
function
#173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
exec
is not a part ofStatement
(https://github.com/TryGhost/node-sqlite3/blob/master/src/statement.cc#L17), but a part ofDatabase
itself (https://github.com/TryGhost/node-sqlite3/blob/master/src/database.cc#L21), it does not supportparams
binding. So, we should not exposeparams
to theexec
public interface here. Also, this corresponds tonode-sqlite3
API docs (https://github.com/TryGhost/node-sqlite3/wiki/API#execsql--callback).