feat: add parameters for cpu quota handling #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the options cpu_period and cpu_quota to the terraform docker_container resource and adds the convenience parameter `cpus` as it is used by the docker cli.
|
I've just realized, that #575 does a similar thing. |
|
Do you like in integrate the changes from #575 I think this would be great and I would love to merge it. |
|
I'm happy to make changes but I think I don't completely get what you meant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the options cpu_period and cpu_quota to the terraform docker_container resource and adds the convenience parameter
cpusas it is used by the docker cli.See https://docs.docker.com/config/containers/resource_constraints/#configure-the-default-cfs-scheduler for upstream details