Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and document distance transform watershed for 2D pmaps/images #318

Merged
merged 8 commits into from
Sep 14, 2024

Conversation

qin-yu
Copy link
Collaborator

@qin-yu qin-yu commented Sep 14, 2024

From my understanding, stacked is just for per-slice processing of 3D pmaps, but for 2D and 3D whole-volume watershed we don't use anything stacked-related.

I documented this in the docstring and also improved the overall documentation as I receive many questions regarding this.

@qin-yu qin-yu added bug Something isn't working enhancement New feature or request GUI Napari GUI related labels Sep 14, 2024
@qin-yu qin-yu self-assigned this Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 62.93103% with 43 lines in your changes missing coverage. Please review.

Project coverage is 66.41%. Comparing base (8aa7747) to head (b9e5a70).
Report is 10 commits behind head on plantsegv2.

Files with missing lines Patch % Lines
plantseg/viewer_napari/widgets/prediction.py 29.16% 34 Missing ⚠️
plantseg/viewer_napari/widgets/segmentation.py 36.36% 7 Missing ⚠️
plantseg/viewer_napari/widgets/dataprocessing.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           plantsegv2     #318      +/-   ##
==============================================
+ Coverage       66.35%   66.41%   +0.06%     
==============================================
  Files              66       67       +1     
  Lines            4541     4571      +30     
==============================================
+ Hits             3013     3036      +23     
- Misses           1528     1535       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qin-yu qin-yu merged commit b3bbe15 into plantsegv2 Sep 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request GUI Napari GUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant