Make VoxelSize iterable and array-like, remove .is_valid
#310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
voxel_size.voxel_size
has been used to get the actual tuple, which is not neat. Now one either uses it directly and let the__len__
,__iter__
, and__array__
handleNone
; or it can be turned into tuple by builtintuple()
.is_valid
property, which doesn't really work with type checkers and is almost not used at all. I safely removed it in favour of checkingNone
directly.