Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BioImage.IO Core: Execute PlantSeg-compatible models by nickname #247

Merged
merged 5 commits into from
May 25, 2024

Conversation

qin-yu
Copy link
Collaborator

@qin-yu qin-yu commented May 25, 2024

New: Predict with models from BioImage.IO Model Zoo

After Zenodo failed BioImage.IO and BioImage.IO's storage moved to EBI, this PR:

The next step is to discuss with BioImage.IO team about filtering models and make PlantSeg community partner.

image

Prediction with PlantSeg Custom/Official models in PlantSeg Zoo is not affected:

image

@qin-yu qin-yu added enhancement New feature or request BioImage.IO Related to BioImage.IO and AI4Life GUI Napari GUI related labels May 25, 2024
@qin-yu qin-yu self-assigned this May 25, 2024
@qin-yu qin-yu marked this pull request as ready for review May 25, 2024 23:28
@qin-yu qin-yu changed the title BioImage.IO Core: Allow execution of PlantSeg-compatible models by nickname BioImage.IO Core: Execute PlantSeg-compatible models by nickname May 25, 2024
@qin-yu qin-yu merged commit af894a7 into master May 25, 2024
1 check passed
@qin-yu
Copy link
Collaborator Author

qin-yu commented May 25, 2024

I believe the introduction of BioImage.IO is significant enough for a new release, potentially v1.8.0. But I suggest we hold off on finalizing this until all related steps are completed.

@lorenzocerrone
Copy link
Collaborator

Hey Qin, looks great! And I am also up for a release.

I have only two points to discuss before releasing:
Screenshot from 2024-05-26 10-36-58

  • When BioImage.IO is selected, should we hide the filters? Since the user needs to select the model name manually, I don't see why keeping them.
  • Is there a tag that can be used to select valid models in the bioimage zoom?

@qin-yu
Copy link
Collaborator Author

qin-yu commented May 26, 2024

I'll do filters but because there is no one forcing users to upload a model with tags, filtering does't guarantee you to find the right models. However, there are ways to check compatibility, which can also be put to BioImage.IO for checking during upload. I'll do these two together as the next step.

For removing the filters for BioImage.IO models we can actually keep them when the checks I mentioned above are done. I can remove them for a brief period. (I actually want to improve the filters because for modality and segmentation type there are more)****

@lorenzocerrone
Copy link
Collaborator

Perfect :) sounds good! Feel free to make a release when you are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BioImage.IO Related to BioImage.IO and AI4Life enhancement New feature or request GUI Napari GUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants