Add nice widgets callbacks #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lorenzocerrone
commented
Apr 13, 2023
•
lorenzocerrone
commented
- Add few magicguis callbacks to improve the user experience
- Setup good default for widgets
- Fix minor bug in headless
- Check version at start and notify if there is a newer version (to be improved) Notify if a new plantseg release is out #145
…s for the z cropping
…s for the z cropping
…o add_nices_widgets_callbacks # Conflicts: # plantseg/viewer/widget/dataprocessing.py
lorenzocerrone
changed the title
|
fixes #142 |
wolny
approved these changes
Apr 14, 2023
plantseg/resources/models_zoo.yaml
Outdated
| @@ -55,7 +55,7 @@ confocal_2D_unet_ovules_ds2x: | |||
| description: "2D Unet trained on z-slices of confocal images of Arabidopsis Ovules (1/2-resolution in XY) with BCEDiceLoss." | |||
| dimensionality: "2D" | |||
| modality: "confocal" | |||
| recommended_patch_size: [ 80, 170, 170 ] | |||
| recommended_patch_size: [ 1, 170, 170 ] | |||
There was a problem hiding this comment.
here we should use [1, 256, 256]
There was a problem hiding this comment.
Done, plus [ 80, 170, 170 ] > [ 80, 160, 160 ], because 170 sounds like a weird choice to me :)
plantseg/resources/models_zoo.yaml
Outdated
| @@ -101,7 +101,7 @@ lightsheet_2D_unet_root_ds1x: | |||
| description: "2D Unet trained on z-slices of light-sheet images of Lateral Root Primordia on original resolution with BCEDiceLoss." | |||
| dimensionality: "2D" | |||
| modality: "light-sheet" | |||
| recommended_patch_size: [ 80, 170, 170 ] | |||
| recommended_patch_size: [ 1, 170, 170 ] | |||
plantseg/resources/models_zoo.yaml
Outdated
| @@ -119,7 +119,7 @@ lightsheet_2D_unet_root_nuclei_ds1x: | |||
| description: "2D Unet trained on z-slices of light-sheet images of Lateral Root Primordia nuclei on original resolution with BCEDiceLoss. The network predicts 2 channels: nuclei mask in the 1st channel, nuclei boundaries in the 2nd channel" | |||
| dimensionality: "2D" | |||
| modality: "light-sheet" | |||
| recommended_patch_size: [ 80, 170, 170 ] | |||
| recommended_patch_size: [ 1, 170, 170 ] | |||
plantseg/utils.py
Outdated
| latest_version = response['tag_name'] | ||
| latest_version_numeric = int(latest_version.replace('.', '')) | ||
| plantseg_version_numeric = int(current_version.replace('.', '')) | ||
| if latest_version_numeric > plantseg_version_numeric: |
There was a problem hiding this comment.
this might not always work though :)
v2.0 > v1.5.1, but this code will convert it to 20 > 151 which is not correct. But assuming we always have major.minor.patch from the bumpversion this should be fine
There was a problem hiding this comment.
It's actually true, also 1.5.11 > 1.6.0. I change it to make it much more robust
| @@ -15,6 +15,8 @@ def parser(): | |||
|
|
|||
|
|
|||
| def main(): | |||
| from plantseg.utils import check_version | |||
| check_version() | |||
There was a problem hiding this comment.
would be good to surround this with try-except clause in case there is a problem with github/network. We should not fail if external service is down
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.