make partial molar volume also a function of temperature

kratman · Dec 5, 2023 · 0fd0385 · 0fd0385
1 parent 31e08c7
commit 0fd0385
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,7 @@
 ## Features
 
 - Serialisation added so models can be written to/read from JSON ([#3397](https://github.com/pybamm-team/PyBaMM/pull/3397))
-- Mechanical parameters are now a function of stoichiometry ([#3576](https://github.com/pybamm-team/PyBaMM/pull/3576))
+- Mechanical parameters are now a function of stoichiometry and temperature ([#3576](https://github.com/pybamm-team/PyBaMM/pull/3576))
 
 ## Bug fixes
 

diff --git a/pybamm/models/submodels/particle/base_particle.py b/pybamm/models/submodels/particle/base_particle.py
@@ -57,7 +57,7 @@ def _get_effective_diffusivity(self, c, T, current):
         if stress_option == "true":
             # Ai2019 eq [12]
             sto = c / phase_param.c_max
-            Omega = pybamm.r_average(domain_param.Omega(sto))
+            Omega = pybamm.r_average(domain_param.Omega(sto, T))
             E = pybamm.r_average(domain_param.E(sto, T))
             nu = domain_param.nu
             theta_M = Omega / (param.R * T) * (2 * Omega * E) / (9 * (1 - nu))

diff --git a/pybamm/models/submodels/particle_mechanics/base_mechanics.py b/pybamm/models/submodels/particle_mechanics/base_mechanics.py
@@ -52,7 +52,7 @@ def _get_mechanical_results(self, variables):
 
         #use a tangential approximation for omega
         sto = variables[f"{Domain} particle concentration"]
-        Omega = pybamm.r_average(domain_param.Omega(sto))
+        Omega = pybamm.r_average(domain_param.Omega(sto, T))
         R0 = domain_param.prim.R
         c_0 = domain_param.c_0
         E0 = pybamm.r_average(domain_param.E(sto, T))

diff --git a/pybamm/parameters/lithium_ion_parameters.py b/pybamm/parameters/lithium_ion_parameters.py
@@ -346,10 +346,10 @@ def C_dl(self, T):
             f"{Domain} electrode double-layer capacity [F.m-2]", inputs
         )
 
-    def Omega(self, sto):
+    def Omega(self, sto, T):
         """Dimensional partial molar volume of Li in solid solution [m3.mol-1]"""
         Domain = self.domain.capitalize()
-        inputs = {f"{Domain} particle stoichiometry": sto}
+        inputs = {f"{Domain} particle stoichiometry": sto, "Temperature [K]": T}
         return pybamm.FunctionParameter(
             f"{Domain} electrode partial molar volume [m3.mol-1]", inputs
         )