Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test on PHP 8.1, 8.2, 8.3 #171

Closed
wants to merge 4 commits into from
Closed

Conversation

SMillerDev
Copy link
Contributor

Also, is there any reason not to use https://github.com/setup-php/setup-php ?

@cmb69
Copy link
Collaborator

cmb69 commented Aug 2, 2024

Closing and re-opening to retrigger CI.

@cmb69 cmb69 closed this Aug 2, 2024
@cmb69 cmb69 reopened this Aug 2, 2024
@SMillerDev
Copy link
Contributor Author

Updated to the latest PHP versions

@SMillerDev SMillerDev changed the title CI: test on PHP 8.2 and 8.1 CI: test on PHP 8.1, 8.2, 8.2 Aug 2, 2024
@SMillerDev SMillerDev changed the title CI: test on PHP 8.1, 8.2, 8.2 CI: test on PHP 8.1, 8.2, 8.3 Aug 2, 2024
@cmb69
Copy link
Collaborator

cmb69 commented Aug 2, 2024

Also, is there any reason not to use https://github.com/setup-php/setup-php ?

Not exactly sure, but I mean to remember that this caused some issues in the past.

Updated to the latest PHP versions

Wow, thanks, that was fast. However, there is apparently a cron schedule in place for running CI; not sure if that's reasonable. Anyway, I'll try to keep an eye on this.

@cmb69 cmb69 closed this Aug 2, 2024
@cmb69 cmb69 reopened this Aug 2, 2024
@cmb69
Copy link
Collaborator

cmb69 commented Aug 2, 2024

Okay, CI is running now; let's see how this goes.

@cmb69
Copy link
Collaborator

cmb69 commented Aug 2, 2024

Due to fail fast behavior, I'm not 100% sure, but at least on Windows tests/007.phpt fails with PHP 8.3:

--
         int(5)
       }
       ["bar"]=>
016-   string(3) "bar"
016+   NULL
     }
     array(2) {
       ["vars"]=>
--

I suggest to test with PHP 8.0, 8.1 and 8.2 for now.

@@ -8,7 +8,7 @@ jobs:
ubuntu:
strategy:
matrix:
version: ["PHP-8.0", "master"]
version: ["PHP-8.1", "PHP-8.2"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still keep the tests for PHP-8.0 (also for Windows below); there are likely users still on this PHP version, and it may even still be supported by some distros.

@cmb69
Copy link
Collaborator

cmb69 commented Aug 2, 2024

Thank you again! I have applied this via 7b70bbf.

@cmb69 cmb69 closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants