Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/156 cors is not a boolean #158

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Feature/156 cors is not a boolean #158

merged 3 commits into from
Sep 30, 2019

Conversation

dcharbonnier
Copy link
Contributor

close #156

@dcharbonnier
Copy link
Contributor Author

is this project dead ?

tlivings
tlivings approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@tlivings tlivings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tlivings tlivings merged commit f470164 into krakenjs:master Sep 30, 2019
@tlivings
Copy link
Contributor

Sorry this took forever.

@tlivings tlivings mentioned this pull request Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlivings tlivings tlivings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cors is not a boolean
2 participants
@dcharbonnier @tlivings