Skip to content
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.

[tech] add support to use the existing dust context #4

Merged
merged 2 commits into from
Dec 30, 2017

Conversation

hegdeashwin
Copy link
Contributor

@hegdeashwin hegdeashwin commented Dec 28, 2017

Changes

  • Add support to use the existing dust context for Node v8 or above.

  • All test are working locally, no change in test cases.

  • Change package version from 0.0.1 to 0.0.2.

References:
LinkedInAttic/dustjs-helpers#146

Copy link

@gabrielcsapo gabrielcsapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the docs? I know there non but this would be a good opportunity to start! Other than that looks good to me!

@grawk
Copy link
Member

grawk commented Dec 29, 2017

backwards compat?

@gabrielcsapo
Copy link

@grawk going to agree with you, this is not backwards compatible.

@hegdeashwin
Copy link
Contributor Author

hegdeashwin commented Dec 29, 2017

Updates

@kumarrishav
Copy link
Member

LGTM now. 👍

@grawk @gabrielcsapo

@grawk
Copy link
Member

grawk commented Dec 30, 2017

Thanks! 👍

@grawk grawk merged commit 4ac703a into krakenjs:master Dec 30, 2017
@grawk
Copy link
Member

grawk commented Dec 30, 2017

Published as [email protected]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants