translation: update searching_algorithm_revisited.md #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo in original commit
RafaelCaso
commented
Nov 13, 2024
|
|
||
| Searching algorithms can be divided into the following two categories based on their implementation approaches. | ||
| Searching algorithms can be divided into the following two categories based on their approach. | ||
|
|
There was a problem hiding this comment.
'Implementation approaches" is redundant (it says the same thing twice). We could also say 'based on their implementation'.
RafaelCaso
commented
Nov 13, 2024
|
|
||
| - **Locating the target element by traversing the data structure**, such as traversals of arrays, linked lists, trees, and graphs, etc. | ||
| - **Using the organizational structure of the data or the prior information contained in the data to achieve efficient element search**, such as binary search, hash search, and binary search tree search, etc. | ||
| - **Using the organizational structure of the data or existing data to achieve efficient element searches**, such as binary search, hash search, binary search tree search, etc. | ||
|
|
There was a problem hiding this comment.
- 'prior information contained in the data' can be shortened. We could also say 'existing information' instead of 'existing data'.
- 'searches' or we could say 'an efficient element search'
RafaelCaso
commented
Nov 13, 2024
|
|
||
| It is not difficult to notice that these topics have been introduced in previous chapters, so searching algorithms are not unfamiliar to us. In this section, we will revisit searching algorithms from a more systematic perspective. | ||
| These topics were introduced in previous chapters, so they are not unfamiliar to us. In this section, we will revisit searching algorithms from a more systematic perspective. | ||
|
|
There was a problem hiding this comment.
- 'it is not difficult to notice' sounds strange in this context (almost pretentious). This is a style suggestion.
- replaced 'searching algorithms' with 'they' because we use it again in the next sentence so it starts to sound repetitive.
RafaelCaso
commented
Nov 13, 2024
| - Not suitable for scenarios with frequent additions and deletions, because maintaining an ordered array incurs high overhead. | ||
| - Suitable for larger data volumes, with stable performance and a worst-case time complexity of $O(\log n)$. | ||
| - However, the data volume cannot be too large, because storing arrays requires contiguous memory space. | ||
| - Not suitable for scenarios with frequent additions and deletions, because maintaining an ordered array incurs a lot of overhead. | ||
|
|
There was a problem hiding this comment.
The first bullet point ('Suitable for large data volumes') seems to directly contradict the second bullet point ('The data volume cannot be too large') so it helps to clarify by adding 'However'.
(I imagine taking notes and seeing 'Suitable for large data volumes' so I write that down -> 'Good for large data'. Then I see 'The data volume cannot be too large' so I write that down -> 'Not good for large data'. With 'However' we clarify that there is a balance we need to be aware of.)
RafaelCaso
commented
Nov 13, 2024
| @@ -1,48 +1,48 @@ | |||
| # Search algorithms revisited | |||
|
|
|||
| <u>Searching algorithms (searching algorithm)</u> are used to search for one or several elements that meet specific criteria in data structures such as arrays, linked lists, trees, or graphs. | |||
| <u>Searching algorithms (search algorithms)</u> are used to retrieve one or more elements that meet specific criteria within data structures such as arrays, linked lists, trees, or graphs. | |||
|
|
|||
There was a problem hiding this comment.
- Keep consistency with the title - "Search algorithms revisited"
- We search for an element but then we need to do something with it - "retrieve"
- the "specific criteria" relates to the element, not the data structure - add 'within' to make this clearer
krahets
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: